Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SSM install script from AL2; SSM is pre-installed on EKS AL based AMIs #8135

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Remove SSM install script from AL2; SSM is pre-installed on EKS AL based AMIs #8135

merged 1 commit into from
Jan 15, 2025

Conversation

bryantbiggs
Copy link
Member

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@bryantbiggs bryantbiggs added area/nodegroup kind/improvement skip-release-notes Causes PR not to show in release notes labels Jan 10, 2025
a-hilaly
a-hilaly approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@bryantbiggs bryantbiggs merged commit 83e5ccc into eksctl-io:main Jan 15, 2025
13 checks passed
@bryantbiggs bryantbiggs deleted the chore/ssm-al2 branch January 15, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

Assignees
No one assigned
Labels
area/nodegroup kind/improvement skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @a-hilaly